Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity translations to Big Ass Fans #95136

Merged
merged 5 commits into from Jun 25, 2023

Conversation

joostlek
Copy link
Member

Proposed change

Add entity translations to Big Ass Fans

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bdraco, @jfroy, mind taking a look at this pull request as it has been labeled with an integration (baf) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of baf can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign baf Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reordering of __init__ seems to cause some problems

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in async_add_entities
    tasks = [
            ^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in <listcomp>
    tasks = [
            ^
  File "/usr/src/homeassistant/homeassistant/components/baf/number.py", line 136, in <genexpr>
    async_add_entities(BAFNumber(device, description) for description in descriptions)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/baf/number.py", line 146, in __init__
    super().__init__(device)
  File "/usr/src/homeassistant/homeassistant/components/baf/entity.py", line 29, in __init__
    self._async_update_attrs()
  File "/usr/src/homeassistant/homeassistant/components/baf/number.py", line 153, in _async_update_attrs
    if (value := self.entity_description.value_fn(self._device)) is not None:
                 ^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'BAFNumber' object has no attribute 'entity_description'
2023-06-24 18:33:19.845 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in async_add_entities
    tasks = [
            ^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in <listcomp>
    tasks = [
            ^
  File "/usr/src/homeassistant/homeassistant/components/baf/sensor.py", line 117, in <genexpr>
    BAFSensor(device, description) for description in sensors_descriptions
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/baf/sensor.py", line 128, in __init__
    super().__init__(device)
  File "/usr/src/homeassistant/homeassistant/components/baf/entity.py", line 29, in __init__
    self._async_update_attrs()
  File "/usr/src/homeassistant/homeassistant/components/baf/sensor.py", line 135, in _async_update_attrs
    description = self.entity_description
                  ^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'BAFSensor' object has no attribute 'entity_description'
2023-06-24 18:33:19.846 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in async_add_entities
    tasks = [
            ^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in <listcomp>
    tasks = [
            ^
  File "/usr/src/homeassistant/homeassistant/components/baf/switch.py", line 126, in <genexpr>
    async_add_entities(BAFSwitch(device, description) for description in descriptions)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/baf/switch.py", line 136, in __init__
    super().__init__(device)
  File "/usr/src/homeassistant/homeassistant/components/baf/entity.py", line 29, in __init__
    self._async_update_attrs()
  File "/usr/src/homeassistant/homeassistant/components/baf/switch.py", line 143, in _async_update_attrs
    self._attr_is_on = self.entity_description.value_fn(self._device)
                       ^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'BAFSwitch' object has no attribute 'entity_description'
2023-06-24 18:33:19.846 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in async_add_entities
    tasks = [
            ^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in <listcomp>
    tasks = [
            ^
  File "/usr/src/homeassistant/homeassistant/components/baf/binary_sensor.py", line 60, in <genexpr>
    BAFBinarySensor(device, description) for description in sensors_descriptions
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/baf/binary_sensor.py", line 71, in __init__
    super().__init__(device)
  File "/usr/src/homeassistant/homeassistant/components/baf/entity.py", line 29, in __init__
    self._async_update_attrs()
  File "/usr/src/homeassistant/homeassistant/components/baf/binary_sensor.py", line 78, in _async_update_attrs
    description = self.entity_description
                  ^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'BAFBinarySensor' object has no attribute 'entity_description'

How did you test this change?

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 24, 2023 23:39
@joostlek joostlek marked this pull request as ready for review June 24, 2023 23:58
@home-assistant home-assistant bot requested a review from bdraco June 24, 2023 23:58
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested, works now.

Thanks @joostlek

@bdraco bdraco merged commit fa334cf into home-assistant:dev Jun 25, 2023
22 of 23 checks passed
@joostlek joostlek deleted the big_ass_fans_entity_translations branch June 25, 2023 00:13
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants