New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entity translations to Big Ass Fans #95136
Add entity translations to Big Ass Fans #95136
Conversation
Hey there @bdraco, @jfroy, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reordering of __init__
seems to cause some problems
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in async_add_entities
tasks = [
^
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in <listcomp>
tasks = [
^
File "/usr/src/homeassistant/homeassistant/components/baf/number.py", line 136, in <genexpr>
async_add_entities(BAFNumber(device, description) for description in descriptions)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/baf/number.py", line 146, in __init__
super().__init__(device)
File "/usr/src/homeassistant/homeassistant/components/baf/entity.py", line 29, in __init__
self._async_update_attrs()
File "/usr/src/homeassistant/homeassistant/components/baf/number.py", line 153, in _async_update_attrs
if (value := self.entity_description.value_fn(self._device)) is not None:
^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'BAFNumber' object has no attribute 'entity_description'
2023-06-24 18:33:19.845 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in async_add_entities
tasks = [
^
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in <listcomp>
tasks = [
^
File "/usr/src/homeassistant/homeassistant/components/baf/sensor.py", line 117, in <genexpr>
BAFSensor(device, description) for description in sensors_descriptions
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/baf/sensor.py", line 128, in __init__
super().__init__(device)
File "/usr/src/homeassistant/homeassistant/components/baf/entity.py", line 29, in __init__
self._async_update_attrs()
File "/usr/src/homeassistant/homeassistant/components/baf/sensor.py", line 135, in _async_update_attrs
description = self.entity_description
^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'BAFSensor' object has no attribute 'entity_description'
2023-06-24 18:33:19.846 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in async_add_entities
tasks = [
^
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in <listcomp>
tasks = [
^
File "/usr/src/homeassistant/homeassistant/components/baf/switch.py", line 126, in <genexpr>
async_add_entities(BAFSwitch(device, description) for description in descriptions)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/baf/switch.py", line 136, in __init__
super().__init__(device)
File "/usr/src/homeassistant/homeassistant/components/baf/entity.py", line 29, in __init__
self._async_update_attrs()
File "/usr/src/homeassistant/homeassistant/components/baf/switch.py", line 143, in _async_update_attrs
self._attr_is_on = self.entity_description.value_fn(self._device)
^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'BAFSwitch' object has no attribute 'entity_description'
2023-06-24 18:33:19.846 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in async_add_entities
tasks = [
^
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 466, in <listcomp>
tasks = [
^
File "/usr/src/homeassistant/homeassistant/components/baf/binary_sensor.py", line 60, in <genexpr>
BAFBinarySensor(device, description) for description in sensors_descriptions
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/baf/binary_sensor.py", line 71, in __init__
super().__init__(device)
File "/usr/src/homeassistant/homeassistant/components/baf/entity.py", line 29, in __init__
self._async_update_attrs()
File "/usr/src/homeassistant/homeassistant/components/baf/binary_sensor.py", line 78, in _async_update_attrs
description = self.entity_description
^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'BAFBinarySensor' object has no attribute 'entity_description'
How did you test this change?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested, works now.
Thanks @joostlek
Proposed change
Add entity translations to Big Ass Fans
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: