New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix control4 light switches on OS 3.3+ #95196
Conversation
Hey there @lawtancool, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Tested here in nalin29/control4RoomMedia#2 using my custom home assistant component that mirrors what is currently pending as a pull request. |
I've marked this PR, as changes are requested that need to be processed. Thanks! 👍 ../Frenck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I have another pull request #90501 that is part of another original larger pull request I made #87821. I was working with a dev to get this merged and had several preliminary smaller PRs successfully merged. However, it seems something happened and its been 3 months without any communication or work done on it. Could you or another dev please take a look or have something done. |
Proposed change
Add new light level variable name that was introduced in OS 3.3+ fixes an old bug documented in #73353
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: