Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix control4 light switches on OS 3.3+ #95196

Merged
merged 2 commits into from Jun 26, 2023
Merged

Conversation

nalin29
Copy link
Contributor

@nalin29 nalin29 commented Jun 25, 2023

Proposed change

Add new light level variable name that was introduced in OS 3.3+ fixes an old bug documented in #73353

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @lawtancool, mind taking a look at this pull request as it has been labeled with an integration (control4) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of control4 can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign control4 Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@nalin29
Copy link
Contributor Author

nalin29 commented Jun 25, 2023

Tested here in nalin29/control4RoomMedia#2 using my custom home assistant component that mirrors what is currently pending as a pull request.

@MartinHjelmare MartinHjelmare changed the title Fix light switches on OS 3.3+ Fix control4 light switches on OS 3.3+ Jun 26, 2023
@frenck
Copy link
Member

frenck commented Jun 26, 2023

I've marked this PR, as changes are requested that need to be processed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

@frenck frenck marked this pull request as draft June 26, 2023 12:29
@nalin29 nalin29 marked this pull request as ready for review June 26, 2023 13:03
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nalin29
Copy link
Contributor Author

nalin29 commented Jun 26, 2023

I have another pull request #90501 that is part of another original larger pull request I made #87821. I was working with a dev to get this merged and had several preliminary smaller PRs successfully merged. However, it seems something happened and its been 3 months without any communication or work done on it. Could you or another dev please take a look or have something done.

@frenck frenck merged commit f08f0fb into home-assistant:dev Jun 26, 2023
19 checks passed
jbouwh pushed a commit to jbouwh/core that referenced this pull request Jun 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control 4 lights no longer with C4 3.3
3 participants