New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Update Entity for Linn devices #95217
Merged
balloob
merged 6 commits into
home-assistant:dev
from
bazwilliams:openhome-update-entity
Jun 28, 2023
Merged
Add Update Entity for Linn devices #95217
balloob
merged 6 commits into
home-assistant:dev
from
bazwilliams:openhome-update-entity
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazwilliams
force-pushed
the
openhome-update-entity
branch
4 times, most recently
from
June 25, 2023 23:51
dea8b30
to
73a91f2
Compare
balloob
reviewed
Jun 26, 2023
balloob
reviewed
Jun 26, 2023
balloob
reviewed
Jun 26, 2023
balloob
reviewed
Jun 26, 2023
balloob
reviewed
Jun 26, 2023
balloob
reviewed
Jun 26, 2023
balloob
reviewed
Jun 26, 2023
balloob
reviewed
Jun 26, 2023
balloob
reviewed
Jun 28, 2023
balloob
reviewed
Jun 28, 2023
balloob
reviewed
Jun 28, 2023
balloob
reviewed
Jun 28, 2023
balloob
reviewed
Jun 28, 2023
balloob
requested changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggested changes. Once applied, and if tests pass, should be good to go 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
bazwilliams
force-pushed
the
openhome-update-entity
branch
from
June 28, 2023 17:47
e451586
to
e23d20b
Compare
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
bazwilliams
force-pushed
the
openhome-update-entity
branch
from
June 28, 2023 17:48
e23d20b
to
8abbc18
Compare
balloob
approved these changes
Jun 28, 2023
Thanks for the help @balloob getting this through. I learned a lot! |
balloob
added a commit
that referenced
this pull request
Jun 29, 2023
* added update entity for Linn devices * Update homeassistant/components/openhome/update.py Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> * use parent methods for version attributes * fixed issue with mocking openhome device * Update homeassistant/components/openhome/update.py Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> * update entity name in tests --------- Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
New software on Linn devices offer Firmware update over the API. This PR adds an
UpdateEntity
for theOpenhome
integration which will show the currently running software and offer upgrade to the latest version if available.This requires a minor bump of the API library.
Type of change
Additional information
None
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: