Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update Entity for Linn devices #95217

Merged
merged 6 commits into from Jun 28, 2023

Conversation

bazwilliams
Copy link
Contributor

@bazwilliams bazwilliams commented Jun 25, 2023

Proposed change

New software on Linn devices offer Firmware update over the API. This PR adds an UpdateEntity for the Openhome integration which will show the currently running software and offer upgrade to the latest version if available.

This requires a minor bump of the API library.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

None

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@balloob balloob marked this pull request as draft June 26, 2023 01:17
@bazwilliams bazwilliams marked this pull request as ready for review June 27, 2023 22:24
@bazwilliams
Copy link
Contributor Author

Conveniently Linn released a firmware update today and I was able to test this integration on real devices.
Screenshot 2023-06-27 at 23 20 32

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggested changes. Once applied, and if tests pass, should be good to go 👍

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 28, 2023 02:28
@bazwilliams bazwilliams marked this pull request as ready for review June 28, 2023 17:48
@home-assistant home-assistant bot requested a review from balloob June 28, 2023 17:48
@bazwilliams
Copy link
Contributor Author

Thanks for the help @balloob getting this through. I learned a lot!

@balloob balloob merged commit aaf2846 into home-assistant:dev Jun 28, 2023
49 of 51 checks passed
@balloob balloob added this to the 2023.7.0 milestone Jun 29, 2023
balloob added a commit that referenced this pull request Jun 29, 2023
* added update entity for Linn devices

* Update homeassistant/components/openhome/update.py

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>

* use parent methods for version attributes

* fixed issue with mocking openhome device

* Update homeassistant/components/openhome/update.py

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>

* update entity name in tests

---------

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants