Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Aranet diagnostic entities appropriately #95218

Merged

Conversation

aschmitz
Copy link
Contributor

@aschmitz aschmitz commented Jun 25, 2023

Proposed change

Turn the Aranet battery and interval sensors into diagnostic sensors, and enable the interval sensor by default.

Type of change

  • Bugfix (non-breaking change which fixes an issue)

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

To help with the load of incoming pull requests:

@frenck
Copy link
Member

frenck commented Jun 26, 2023

I've marked this PR, as changes are requested that need to be processed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

@frenck frenck marked this pull request as draft June 26, 2023 12:25
@aschmitz aschmitz marked this pull request as ready for review June 27, 2023 03:19
@aschmitz
Copy link
Contributor Author

Fixed the review comments (thanks, @Noltari!), though the commit history isn't the cleanest. I wanted to avoid a force-push and I assume you'll squash when merging, but if not let me know and I can rebase and flatten this to a single commit.

Copy link
Contributor

@Noltari Noltari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Noltari
Copy link
Contributor

Noltari commented Jun 27, 2023

Fixed the review comments (thanks, @Noltari!), though the commit history isn't the cleanest. I wanted to avoid a force-push and I assume you'll squash when merging, but if not let me know and I can rebase and flatten this to a single commit.

There's no need to rebase because it will be squashed when merged, so don't worry about that :)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aschmitz 👍

../Frenck

@frenck frenck merged commit 1dc9c77 into home-assistant:dev Jun 27, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aranet integration should set entity_category=EntityCategory.DIAGNOSTIC for the battery sensor
3 participants