New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag Aranet diagnostic entities appropriately #95218
Tag Aranet diagnostic entities appropriately #95218
Conversation
I've marked this PR, as changes are requested that need to be processed. Thanks! 👍 ../Frenck |
…com/aschmitz/homeassistant-core into aranet-diagnostic-sensor-categories
Fixed the review comments (thanks, @Noltari!), though the commit history isn't the cleanest. I wanted to avoid a force-push and I assume you'll squash when merging, but if not let me know and I can rebase and flatten this to a single commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There's no need to rebase because it will be squashed when merged, so don't worry about that :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @aschmitz 👍
../Frenck
Proposed change
Turn the Aranet battery and interval sensors into diagnostic sensors, and enable the interval sensor by default.
Type of change
Additional information
entity_category=EntityCategory.DIAGNOSTIC
for the battery sensor #95197Checklist
black --fast homeassistant tests
)To help with the load of incoming pull requests: