Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Change the device class name volatile organic compounds parts to VOCs ratio" #95332

Merged
merged 1 commit into from Jun 27, 2023
Merged

Revert "Change the device class name volatile organic compounds parts to VOCs ratio" #95332

merged 1 commit into from Jun 27, 2023

Conversation

emontnemery
Copy link
Contributor

Reverts #95126

We intentionally gave the same name to volatile_organic_compounds_parts and volatile_organic_compounds
Let's try to solve the device class selector issue separately

@emontnemery emontnemery requested a review from a team as a code owner June 27, 2023 08:08
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (sensor) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sensor can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sensor Removes the current integration label and assignees on the pull request, add the integration domain after the command.

frenck
frenck approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking on Discord about it, I agree. 👍

../Frenck

@frenck frenck mentioned this pull request Jun 27, 2023
Merged
@MartinHjelmare MartinHjelmare merged commit 3c015f8 into dev Jun 27, 2023
51 checks passed
@MartinHjelmare MartinHjelmare deleted the revert-95126-sensor-voc_parts]-name branch June 27, 2023 10:28
@emontnemery emontnemery mentioned this pull request Jun 27, 2023
Closed
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed core integration: sensor Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emontnemery @frenck @MartinHjelmare