Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up wheels building, removing cp310 abi #95334

Merged
merged 1 commit into from Jun 27, 2023
Merged

Clean up wheels building, removing cp310 abi #95334

merged 1 commit into from Jun 27, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Jun 27, 2023

Breaking change

Python wheels for the cp310 abi are no longer built (Python 3.10 wheels).
This classifies as a breaking change but has no effect on our ecosystem.

Proposed change

SSIA, cleans up the Python wheels building for Python 3.10 (cp310).
All our images are now based on Python 3.11, so we no longer have to build/maintain the wheels for 3.10.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added breaking-change cla-signed small-pr PRs with less than 30 lines. labels Jun 27, 2023
@frenck
Copy link
Member Author

frenck commented Jun 27, 2023

The CI failures are not related to this PR, therefore going to merge this one in.

../Frenck

@frenck frenck merged commit 39f76b7 into dev Jun 27, 2023
44 of 47 checks passed
@frenck frenck deleted the frenck-2023-0910 branch June 27, 2023 09:53
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants