Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to stop action #95376

Merged
merged 1 commit into from Jun 27, 2023
Merged

Add test to stop action #95376

merged 1 commit into from Jun 27, 2023

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 27, 2023

Breaking change

Proposed change

Test for the stop action not allow setting both error and response_variable. Test by @allenporter #95284 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@balloob balloob requested a review from a team as a code owner June 27, 2023 12:27
@frenck frenck added this to the 2023.7.0b0 milestone Jun 27, 2023
@balloob balloob marked this pull request as draft June 27, 2023 13:43
@balloob
Copy link
Member Author

balloob commented Jun 27, 2023

Drafting and will redo once #95346 is merged.

@frenck
Copy link
Member

frenck commented Jun 27, 2023

#95346 has been merged.

@balloob balloob marked this pull request as ready for review June 27, 2023 16:43
@frenck frenck merged commit 243abf3 into dev Jun 27, 2023
51 checks passed
@frenck frenck deleted the add-test-stop-action branch June 27, 2023 17:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants