Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneded construct import for Eddystone #95418

Merged
merged 1 commit into from Jun 28, 2023

Conversation

Lash-L
Copy link
Contributor

@Lash-L Lash-L commented Jun 27, 2023

Breaking change

Proposed change

I am working on a problem with construct in the Roborock integration, and I realized that the construct version is hardlocked in homeassistant in three places

  1. Eddystone - not used in the actual integration - only in the base package, where it is set to 'construct>=2.9.52,<2.11'
  2. eq3btsmart (Remove unneeded construct import for Eq3btsmart #95419)- not used in the actual integration - only in the base pacakge, where it is set to "*"
  3. xiaomi_miio - used in the integration only for error checking

For all of these - the actual integration has no real dependence on construct, just the package, and as such, the dependency should probably only be specified inside the package

Feel free to tell me if this is wrong for any reason.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Lash-L 👍

@frenck frenck merged commit f6aae8b into home-assistant:dev Jun 28, 2023
51 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants