New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entity translations to HVV Departures #95442
Add entity translations to HVV Departures #95442
Conversation
Hey there @vigonotion, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @joostlek 👍
@@ -58,15 +58,15 @@ class HVVDepartureSensor(SensorEntity): | |||
_attr_attribution = ATTRIBUTION | |||
_attr_device_class = SensorDeviceClass.TIMESTAMP | |||
_attr_icon = ICON | |||
_attr_translation_key = "departures" | |||
_attr_has_entity_name = True | |||
_attr_extra_state_attributes = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't initialize a class attribute to a mutable object. That's error prone and rarely needed.
If this platform would have added more than one sensor entity, every time one entity updated its state attributes, all sensor instances would get that update to their state attributes dict.
I noticed there are no tests for this integration and you haven't checked the boxes in the PR description about testing your change. Did you do that? |
Proposed change
Add entity translations to HVV Departures
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: