Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error for stt when async_get_engine is not implemented #95443

Merged
merged 3 commits into from Jun 28, 2023

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Jun 28, 2023

Proposed change

Fix error for stt when async_get_engine is not implemented.

When the demo platform is set up. The following error is logged:

2023-06-28 08:04:55.746 ERROR (MainThread) [homeassistant.components.stt.legacy] Error setting up platform: demo
Traceback (most recent call last):
  File "/workspaces/core/homeassistant/components/stt/legacy.py", line 68, in async_setup_platform
    provider = await platform.async_get_engine(hass, p_config, discovery_info)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'homeassistant.components.demo.stt' has no attribute 'async_get_engine'

This PR fixes this by checking removing the legacy stt platform from the demo integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, @pvizeli, mind taking a look at this pull request as it has been labeled with an integration (stt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of stt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign stt Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@emontnemery
Copy link
Contributor

emontnemery commented Jun 28, 2023

I think this should be fixed in the demo integration, not in stt, by removing this line

This should have been done in #94585, but was forgotten

@jbouwh jbouwh merged commit 0a74bff into home-assistant:dev Jun 28, 2023
47 checks passed
@jbouwh jbouwh deleted the fix-tts-demo-error branch June 28, 2023 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants