New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update matter locks to support pin code validation #95481
Update matter locks to support pin code validation #95481
Conversation
Hi @evanjarrett It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
def code_format(self) -> str | None: | ||
"""Regex for code format or None if no code is required.""" | ||
if self.get_matter_attribute_value( | ||
clusters.DoorLock.Attributes.RequirePINforRemoteOperation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this is dynamic value (e.g. configurable on the lock) or just static ?
In case its dynamic, these attributes should be added to the "optional_attributes" property of the Lock platform discovery schema to setup the subscription for state updates. If its just static the value will come (once) with the interview of the device.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specs are a bit unclear about it but it seems to be a static device-specific value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Update matter locks to support PINCode validation based on device attributes
Proposed change
Add pincode validation to matter locks that require pincode for remote operation.
Type of change
Additional information
This is a follow up of a previous bug report.
Matter Locks was updated to send pin codes if provided (#95402), but without a code_format defined, the UI would ignore codes.
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: