Remove incompatible button entities for Mazda electric vehicles #95486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: mazda
small-pr
joostlek
reviewed
Jun 28, 2023
| @@ -65,40 +65,6 @@ async def test_button_setup_electric_vehicle(hass: HomeAssistant) -> None: | |||
|
|
|||
| entity_registry = er.async_get(hass) | |||
|
|
|||
| entry = entity_registry.async_get("button.my_mazda3_start_engine") | |||
There was a problem hiding this comment.
Would adding tests that check if the entities are not present if the vehicle is electric be benificial?
There was a problem hiding this comment.
Good idea. I just added tests for that.
balloob
approved these changes
Jun 29, 2023
balloob
pushed a commit
that referenced
this pull request
Jun 29, 2023
* Remove incompatible button entities for Mazda electric vehicles * Update tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
In the Mazda integration, the Mazda API does not support start engine, stop engine, and hazard lights functionality for electric vehicles. Therefore this PR removes those entities for only those vehicles. I don't believe this is a breaking change since those entities were already non-functional, but let me know if I'm incorrect.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: