Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark text input required for conversation.process service #95520

Merged
merged 1 commit into from Jun 29, 2023
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Jun 29, 2023

Proposed change

SSIA, Without a text, it would be pretty much useless.

CleanShot 2023-06-29 at 11 30 22

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of conversation can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign conversation Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind that the documentation needs an update as well.
https://www.home-assistant.io/integrations/conversation/
LGTM,
Thnx @frenck 👍

@frenck frenck marked this pull request as draft June 29, 2023 09:54
@frenck
Copy link
Member Author

frenck commented Jun 29, 2023

Documentation was already correct on the next branch.

CleanShot 2023-06-29 at 17 37 33

@frenck frenck marked this pull request as ready for review June 29, 2023 15:39
@frenck frenck merged commit 23e23ae into dev Jun 29, 2023
51 checks passed
@frenck frenck deleted the frenck-2023-0924 branch June 29, 2023 15:39
@jbouwh
Copy link
Contributor

jbouwh commented Jun 29, 2023

I had a look at the docs in the next branch. It seems text is already required, so no need to update that again.

@jbouwh
Copy link
Contributor

jbouwh commented Jun 29, 2023

I had a look at the docs in the next branch. It seems text is already required, so no need to update that again.

Had to refresh my browser

@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants