Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix source device when source entity is changed for Utility Meter #95636

Merged
merged 5 commits into from Jul 3, 2023
Merged

Fix source device when source entity is changed for Utility Meter #95636

merged 5 commits into from Jul 3, 2023

Conversation

dougiteixeira
Copy link
Contributor

Breaking change

None

Proposed change

Utility Meter integration has configuration option to change source entity, this PR includes handling to remove configuration entry from device registry in case of change of source entity.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (utility_meter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of utility_meter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign utility_meter Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@dougiteixeira
Copy link
Contributor Author

This PR needs to be included in the next release because PR #94734 has been included in the beta.

@balloob balloob added this to the 2023.7.0 milestone Jun 30, 2023
@balloob balloob marked this pull request as draft June 30, 2023 21:25
@dougiteixeira dougiteixeira marked this pull request as ready for review July 1, 2023 00:33
@balloob balloob merged commit 75bdb03 into home-assistant:dev Jul 3, 2023
22 of 23 checks passed
balloob added a commit that referenced this pull request Jul 3, 2023
@dougiteixeira @balloob
Fix source device when source entity is changed for Utility Meter (#9…
3fa009b 
…5636)

* Fix source device when source entity is changed

* Update loop

* Complement and add comments in the test_change_device_source test

* Only clean up dev reg when options change

---------

Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@dougiteixeira dougiteixeira deleted the fix-device-source-change-utility_meter branch July 3, 2023 12:09
@dougiteixeira dougiteixeira restored the fix-device-source-change-utility_meter branch July 3, 2023 12:09
@dougiteixeira dougiteixeira deleted the fix-device-source-change-utility_meter branch July 3, 2023 12:09
@dougiteixeira dougiteixeira restored the fix-device-source-change-utility_meter branch July 3, 2023 12:09
@dougiteixeira dougiteixeira deleted the fix-device-source-change-utility_meter branch July 3, 2023 12:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

@dgomes dgomes Awaiting requested review from dgomes dgomes is a code owner

Assignees

@dgomes dgomes

Labels
bugfix cherry-picked cla-signed has-tests integration: utility_meter Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dougiteixeira @balloob @dgomes