Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate between device info types #95641

Merged
merged 16 commits into from
Jul 10, 2023
Merged

Differentiate between device info types #95641

merged 16 commits into from
Jul 10, 2023

Commits on Jul 6, 2023

  1. Differentiate between device info types

    @balloob
    balloob committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    c1b57f2 View commit details
    Browse the repository at this point in the history

  2. Update allowed fields

    @balloob
    balloob committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    fd33608 View commit details
    Browse the repository at this point in the history

  3. Update homeassistant/helpers/entity_platform.py 

    Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
    @balloob @MartinHjelmare
    balloob and MartinHjelmare committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ab83a56 View commit details
    Browse the repository at this point in the history

  4. Split up message in 2 lines

    @balloob
    balloob committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    61ab966 View commit details
    Browse the repository at this point in the history

  5. Use dict for device info types

    @balloob
    balloob committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    592de14 View commit details
    Browse the repository at this point in the history

  6. Extract device info function and test error checking

    @balloob
    balloob committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    409fbe7 View commit details
    Browse the repository at this point in the history

  7. Simplify parsing device info

    @balloob
    balloob committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    4ed6c4c View commit details
    Browse the repository at this point in the history

  8. move checks around

    @balloob
    balloob committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    2cfd1f1 View commit details
    Browse the repository at this point in the history

  9. Simplify more

    @balloob
    balloob committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    5f33f97 View commit details
    Browse the repository at this point in the history

  10. Move error checking around

    @balloob
    balloob committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1919d34 View commit details
    Browse the repository at this point in the history

  11. Fix order

    @balloob
    balloob committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    6708b35 View commit details
    Browse the repository at this point in the history

  12. fallback config entry title to domain

    @balloob
    balloob committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    9c3bb44 View commit details
    Browse the repository at this point in the history

  13. Remove fallback for name to config entry domain

    @balloob
    balloob committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    c56794c View commit details
    Browse the repository at this point in the history

  14. Ensure mocked configuration URLs are strings

    @balloob
    balloob committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    646e221 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. one more test case

    @balloob
    balloob committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    35ab721 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Erik Montnemery <erik@montnemery.com>
    @balloob @emontnemery
    balloob and emontnemery committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    206dcee View commit details
    Browse the repository at this point in the history