Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ezviz SensorEntity name and translation #95697

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

RenierM26
Copy link
Contributor

Proposed change

Add proper names to EZVIZ sensor entities and add translation key.

I have a few open pull requests; this one has no dependency on others.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jul 2, 2023

Hey there @BaQs, mind taking a look at this pull request as it has been labeled with an integration (ezviz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ezviz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ezviz Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@RenierM26 RenierM26 marked this pull request as ready for review July 2, 2023 07:43
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 7, 2023
homeassistant/components/ezviz/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/ezviz/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft July 10, 2023 13:49
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Jul 10, 2023
@RenierM26 RenierM26 marked this pull request as ready for review July 10, 2023 16:15
@home-assistant home-assistant bot requested a review from frenck July 10, 2023 16:15
@MartinHjelmare MartinHjelmare changed the title Ezviz SensorEntity name and translation Add Ezviz SensorEntity name and translation Jul 13, 2023
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflict

@home-assistant home-assistant bot marked this pull request as draft July 13, 2023 12:55
@RenierM26 RenierM26 marked this pull request as ready for review July 14, 2023 17:25
@home-assistant home-assistant bot requested review from frenck and joostlek July 14, 2023 17:25
@home-assistant home-assistant bot marked this pull request as draft July 14, 2023 17:30
@RenierM26 RenierM26 marked this pull request as ready for review July 14, 2023 17:42
@home-assistant home-assistant bot requested a review from joostlek July 14, 2023 17:43
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, second opinion needed

@joostlek joostlek added the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Jul 14, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Thanks, @RenierM26!

../Frenck

@frenck frenck merged commit 33b3b89 into home-assistant:dev Jul 19, 2023
23 checks passed
@RenierM26 RenierM26 deleted the ezviz_sensor_naming branch July 19, 2023 20:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants