New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add power service to System Bridge integration #95719
Add power service to System Bridge integration #95719
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
161a290
to
d791430
Compare
This comment was marked as outdated.
This comment was marked as outdated.
d791430
to
f3e76fc
Compare
e7584b8
to
8577a52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seem alright and it does fix the previous style issue from #72867 (comment)
Thus I gues it can be merged
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Add missing return types Use in list validator and fix command
8577a52
to
870a663
Compare
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed change
Adds new power command service to System Bridge integration.
Continution of #72867 addressing review.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: