Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add power service to System Bridge integration #95719

Merged
merged 4 commits into from Aug 28, 2023

Conversation

timmo001
Copy link
Contributor

@timmo001 timmo001 commented Jul 2, 2023

Proposed change

Adds new power command service to System Bridge integration.

Continution of #72867 addressing review.

Type of change

  • New feature (which adds functionality to an existing integration)

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant

This comment was marked as outdated.

@home-assistant

This comment was marked as outdated.

@timmo001 timmo001 force-pushed the system-bridge-power-services branch from e7584b8 to 8577a52 Compare July 4, 2023 11:29
Copy link

@BenoitAnastay BenoitAnastay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem alright and it does fix the previous style issue from #72867 (comment)

Thus I gues it can be merged

@home-assistant home-assistant bot marked this pull request as draft July 24, 2023 21:16
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

timmo001 and others added 2 commits July 26, 2023 10:59
Add missing return types

Use in list validator and fix command
@timmo001 timmo001 force-pushed the system-bridge-power-services branch from 8577a52 to 870a663 Compare July 26, 2023 11:00
@timmo001 timmo001 marked this pull request as ready for review July 26, 2023 11:12
@home-assistant home-assistant bot requested a review from joostlek July 26, 2023 11:12
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@joostlek joostlek added the smash Indicator this PR is close to finish for merging or closing label Jul 26, 2023
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joostlek joostlek merged commit 42597f8 into home-assistant:dev Aug 28, 2023
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants