New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Komfovent #95722
Add Komfovent #95722
Conversation
Hi @ProstoSanja It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Hello, just out of curiosity, is there anything missing in this PR, or is the backlog just this big? I am not really familiar with your process here. Thanks |
resolved |
Hello, @joostlek , any chance we can try and push this forward again? Everything seems to be resolved from my side. Thanks and sorry for the ping, just trying to make sure it doesn’t get lost. If you have some process like running these things once a month or something, lmk so i don’t bother you without reason, thanks! |
I would prefer the device name over the hostname for the entry title. I think that's a more user friendly way, but it depends on the context |
Just a bit confused by what you mean by device name here, the information I am sending to hass is the following:
So which one of these should be entry name? |
Hmm, good question, I'll ask this tomorrow. From what I see this PR is near completion :) |
I just discussed this, we should use the name of the device for the initial config entry title. After that I think this should be about done |
should be all resolved 👍🏻 |
Looks like some unrelated tests failed. Something I should be concerned about? |
@joostlek should I do something from my side? |
Reran them last time but forgot to leave a comment. When they pass I will merge it :P |
* komfovent integration V1 * add dependency * integrate komfovent api * fix errors found in testing * tests for form handling * update deps * update coverage rc * add correct naming * minor feedback * pre-commit fixes * feedback fixes part 1 of 2 * feedback fixes part 2 of 2 * add hvac mode support * fix tests * address feedback * fix code coverage + PR feedback * PR feedback * use device name --------- Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Proposed change
Implement integration for "Komfovent" climate units, that are used primarily in North and East Europe.
They have a very simplistic authentication with user/password based on ip addresses, and support changing the operating modes, setting up some params, and looking up the current status.
Only part of those features is integrated:
Other parts may or may not be added by me in the future, depending on my availability and necessity coming from other people.
This integration is fully local. The actual integration part is available in my repo.
Integration was tested directly with the C6 controller unit, which to my knowledge is their most popular one in residential installs.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: