Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Komfovent #95722

Merged
merged 38 commits into from Nov 11, 2023
Merged

Add Komfovent #95722

merged 38 commits into from Nov 11, 2023

Conversation

ProstoSanja
Copy link
Contributor

@ProstoSanja ProstoSanja commented Jul 2, 2023

Proposed change

Implement integration for "Komfovent" climate units, that are used primarily in North and East Europe.
They have a very simplistic authentication with user/password based on ip addresses, and support changing the operating modes, setting up some params, and looking up the current status.
Only part of those features is integrated:

  • auth
  • reading state of current mode and temperature
  • setting a different operating state

Other parts may or may not be added by me in the future, depending on my availability and necessity coming from other people.
This integration is fully local. The actual integration part is available in my repo.
Integration was tested directly with the C6 controller unit, which to my knowledge is their most popular one in residential installs.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jul 2, 2023

Hi @ProstoSanja

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ProstoSanja ProstoSanja marked this pull request as draft July 6, 2023 11:43
@ProstoSanja ProstoSanja marked this pull request as ready for review July 6, 2023 11:43
@ProstoSanja
Copy link
Contributor Author

ProstoSanja commented Jul 6, 2023

Hello, just out of curiosity, is there anything missing in this PR, or is the backlog just this big? I am not really familiar with your process here. Thanks

@ProstoSanja
Copy link
Contributor Author

resolved

@ProstoSanja ProstoSanja marked this pull request as ready for review October 8, 2023 15:48
@ProstoSanja
Copy link
Contributor Author

Hello, @joostlek , any chance we can try and push this forward again? Everything seems to be resolved from my side.

Thanks and sorry for the ping, just trying to make sure it doesn’t get lost. If you have some process like running these things once a month or something, lmk so i don’t bother you without reason, thanks!

homeassistant/components/komfovent/climate.py Outdated Show resolved Hide resolved
homeassistant/components/komfovent/climate.py Show resolved Hide resolved
homeassistant/components/komfovent/strings.json Outdated Show resolved Hide resolved
homeassistant/components/komfovent/strings.json Outdated Show resolved Hide resolved
tests/components/komfovent/test_config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/komfovent/__init__.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft October 31, 2023 09:51
@ProstoSanja ProstoSanja marked this pull request as ready for review October 31, 2023 19:54
@joostlek
Copy link
Member

I would prefer the device name over the hostname for the entry title. I think that's a more user friendly way, but it depends on the context

@ProstoSanja
Copy link
Contributor Author

I would prefer the device name over the hostname for the entry title. I think that's a more user friendly way, but it depends on the context

Just a bit confused by what you mean by device name here, the information I am sending to hass is the following:

  1. manufacturer: Komfovent
  2. model: C60
  3. friendly name: set by user in the native webUI
  4. serial number

So which one of these should be entry name?
if we are talking about friendly name, which i just now set as device name, is it being duplicate okay? And what if it changes outside of hass, will it be picked up?

@joostlek
Copy link
Member

Hmm, good question, I'll ask this tomorrow. From what I see this PR is near completion :)

@joostlek
Copy link
Member

joostlek commented Nov 2, 2023

I just discussed this, we should use the name of the device for the initial config entry title. After that I think this should be about done

@ProstoSanja
Copy link
Contributor Author

should be all resolved 👍🏻

@ProstoSanja
Copy link
Contributor Author

Looks like some unrelated tests failed. Something I should be concerned about?

@ProstoSanja
Copy link
Contributor Author

Looks like some unrelated tests failed. Something I should be concerned about?

@joostlek should I do something from my side?

@joostlek
Copy link
Member

Reran them last time but forgot to leave a comment. When they pass I will merge it :P

@joostlek joostlek added the smash Indicator this PR is close to finish for merging or closing label Nov 10, 2023
@joostlek joostlek dismissed stale reviews from frenck and jpbede November 10, 2023 22:44

Changes implemented

@joostlek joostlek merged commit f3cccf0 into home-assistant:dev Nov 11, 2023
53 checks passed
dgomes pushed a commit to dgomes/home-assistant that referenced this pull request Nov 11, 2023
* komfovent integration V1

* add dependency

* integrate komfovent api

* fix errors found in testing

* tests for form handling

* update deps

* update coverage rc

* add correct naming

* minor feedback

* pre-commit fixes

* feedback fixes part 1 of 2

* feedback fixes part 2 of 2

* add hvac mode support

* fix tests

* address feedback

* fix code coverage + PR feedback

* PR feedback

* use device name

---------

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed has-tests integration: komfovent new-integration smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants