New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix datetime parameter validation for list events #95778
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@@ -67,6 +67,14 @@ async def async_get_events( | |||
end_date: datetime.datetime, | |||
) -> list[CalendarEvent]: | |||
"""Return calendar events within a datetime range.""" | |||
if start_date.tzinfo is None: | |||
start_date = start_date.replace( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug in list_events
so we can move the logic into list_events
similar to the other caller
calendar_event_list = await entity.async_get_events( |
dt_util.as_local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sent #95804 to fix the list events bug
Proposed change
Fix datetime parameter validation for list events. I also fixed the demo calendar integration to use the server timezone
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: