Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reload in cert_expiry #95867

Merged
merged 3 commits into from Jul 4, 2023
Merged

Fix reload in cert_expiry #95867

merged 3 commits into from Jul 4, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 4, 2023

Proposed change

Switches async_listen_once to async_listen since its wrapped in entry.async_on_unload and the listener will fail to be removed on reload once the started event has fired because it was a one time listener (and already removed).

This could be refactored later to avoid calling the callable that async_listen_once returns once the started event has fired but that would add more complexity and since the started event is only fired once it doesn't have a performance penalty to use async_listen instead

fixes #95823

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Switches async_listen_once to async_listen since its wrapped in entry.async_on_unload
and the listener will fail to be removed on reload once the started event has fired
because it was a one time listener
@home-assistant
Copy link

home-assistant bot commented Jul 4, 2023

Hey there @Cereal2nd, @jjlawren, mind taking a look at this pull request as it has been labeled with an integration (cert_expiry) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cert_expiry can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign cert_expiry Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco marked this pull request as ready for review July 4, 2023 14:59
@bdraco bdraco requested a review from jjlawren as a code owner July 4, 2023 14:59
@bdraco
Copy link
Member Author

bdraco commented Jul 4, 2023

It was simple enough to change out so lets do it now. I think the risk is very low as I have a lot of these and was able to test before and after startup

@bdraco
Copy link
Member Author

bdraco commented Jul 4, 2023

thanks 👍

@bdraco bdraco merged commit ea160c2 into dev Jul 4, 2023
23 checks passed
@bdraco bdraco deleted the cert_expiry_reload_after_started branch July 4, 2023 17:13
frenck pushed a commit that referenced this pull request Jul 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to remove unknown job listener _FilterableJob(job=<Job onetime listen
4 participants