New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reload in cert_expiry #95867
Merged
Merged
Fix reload in cert_expiry #95867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches async_listen_once to async_listen since its wrapped in entry.async_on_unload and the listener will fail to be removed on reload once the started event has fired because it was a one time listener
home-assistant
bot
added
bugfix
cla-signed
integration: cert_expiry
small-pr
PRs with less than 30 lines.
labels
Jul 4, 2023
Hey there @Cereal2nd, @jjlawren, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
MartinHjelmare
approved these changes
Jul 4, 2023
It was simple enough to change out so lets do it now. I think the risk is very low as I have a lot of these and was able to test before and after startup |
jjlawren
approved these changes
Jul 4, 2023
thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
cherry-picked
cla-signed
integration: cert_expiry
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Switches
async_listen_once
toasync_listen
since its wrapped inentry.async_on_unload
and the listener will fail to be removed on reload once the started event has fired because it was a one time listener (and already removed).This could be refactored later to avoid calling the callable that
async_listen_once
returns once the started event has fired but that would add more complexity and since the started event is only fired once it doesn't have a performance penalty to useasync_listen
insteadfixes #95823
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: