Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle switch to Daikin HVAC units #95954

Merged
merged 9 commits into from Nov 24, 2023
Merged

Conversation

disforw
Copy link
Contributor

@disforw disforw commented Jul 6, 2023

Breaking change

Proposed change

This PR adds a switch entity to each device allowing it to be easily switched on and off. This is especially helpful when using Mini-split units.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jul 6, 2023

Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration (daikin) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of daikin can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign daikin Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@disforw
Copy link
Contributor Author

disforw commented Aug 19, 2023

Adding a simple on/off switch to sit besides the climate. I can disable it by default if you want.

Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 17, 2023
@github-actions github-actions bot closed this Nov 24, 2023
@frenck frenck reopened this Nov 24, 2023
@github-actions github-actions bot removed the stale label Nov 24, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @disforw 👋

I've rebased your PR, there is a CI error. Could you take a look?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft November 24, 2023 10:36
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Add import of DeviceInfo
@disforw disforw marked this pull request as ready for review November 24, 2023 13:42
@home-assistant home-assistant bot requested a review from frenck November 24, 2023 13:42
homeassistant/components/daikin/switch.py Outdated Show resolved Hide resolved
homeassistant/components/daikin/switch.py Outdated Show resolved Hide resolved
homeassistant/components/daikin/switch.py Outdated Show resolved Hide resolved
homeassistant/components/daikin/switch.py Outdated Show resolved Hide resolved
homeassistant/components/daikin/switch.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 24, 2023 15:36
disforw and others added 5 commits November 24, 2023 11:20
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@disforw
Copy link
Contributor Author

disforw commented Nov 24, 2023

@frenck noted. Thank you.

@disforw disforw marked this pull request as ready for review November 24, 2023 16:30
@home-assistant home-assistant bot requested a review from frenck November 24, 2023 16:30
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @disforw 👍

../Frenck

@frenck frenck merged commit 95cfe41 into home-assistant:dev Nov 24, 2023
22 of 23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants