Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ESPHome dashboard connection recovers if its down when core starts #96449

Merged
merged 4 commits into from Jul 13, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 12, 2023

Proposed change

If the dashboard was down (or not started yet) at startup, we would not try again later to connect until core was restarted.

fixes #96447

Unfortunately it means we end up reloading all the entries when it does come back online later but thats still better than being offline forever. Ideally supervisor would start the dashboard before core so this condition doesn't ever happen but that is outside the scope of core.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

…very

If the dashboard was down at startup, we would not try again
later to connect until core was restarted.

fixes #96447
@home-assistant
Copy link

Hey there @OttoWinter, @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco marked this pull request as draft July 12, 2023 20:08
@bdraco
Copy link
Member Author

bdraco commented Jul 12, 2023

Need to test this on production as well but can’t take my dashboard down right now

@bdraco
Copy link
Member Author

bdraco commented Jul 12, 2023

This fixes it, but it's also confusing if the dashboard doesn't know about the device it reports as unavailable instead of unknown. That's a different problem though for another pr #96455

@bdraco bdraco marked this pull request as ready for review July 12, 2023 21:41
@bdraco
Copy link
Member Author

bdraco commented Jul 13, 2023

thanks

@bdraco bdraco merged commit 7009683 into dev Jul 13, 2023
19 checks passed
@bdraco bdraco deleted the dashboard_down_startup branch July 13, 2023 00:37
@balloob balloob mentioned this pull request Jul 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESPHome Firmware Status Unavailable - returned
4 participants