New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure ESPHome dashboard connection recovers if its down when core starts #96449
Conversation
…very If the dashboard was down at startup, we would not try again later to connect until core was restarted. fixes #96447
Hey there @OttoWinter, @jesserockz, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Need to test this on production as well but can’t take my dashboard down right now |
This fixes it, but it's also confusing if the dashboard doesn't know about the device it reports as unavailable instead of unknown. That's a different problem though for another pr #96455 |
thanks |
Proposed change
If the dashboard was down (or not started yet) at startup, we would not try again later to connect until core was restarted.
fixes #96447
Unfortunately it means we end up reloading all the entries when it does come back online later but thats still better than being offline forever. Ideally supervisor would start the dashboard before core so this condition doesn't ever happen but that is outside the scope of core.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: