Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MyStrom switch 120 #96535

Merged
merged 1 commit into from Jul 14, 2023
Merged

Support MyStrom switch 120 #96535

merged 1 commit into from Jul 14, 2023

Conversation

joostlek
Copy link
Member

Proposed change

Support MyStrom switch 120, like it used to before the config flow update

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (mystrom) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mystrom can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mystrom Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Switch Zero (Type 120) is a feature-limited version of 106

@joostlek
Copy link
Member Author

Looks good to me. Switch Zero (Type 120) is a feature-limited version of 106

Just tested it together with the issue creator :)

@joostlek joostlek added this to the 2023.7.2 milestone Jul 14, 2023
@balloob balloob modified the milestones: 2023.7.2, 2023.7.3 Jul 14, 2023
@balloob balloob merged commit 1b7632a into home-assistant:dev Jul 14, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2023
@joostlek joostlek deleted the mystrom_120 branch July 15, 2023 14:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration Problem with myStrom Adapter from Swisscom
4 participants