Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure androidtv_remote does not block startup of HA #96582

Merged
merged 9 commits into from Jul 20, 2023

Conversation

quthla
Copy link
Contributor

@quthla quthla commented Jul 15, 2023

Breaking change

Proposed change

The integration does keep HA from finishing start up for more than 2 minutes because the downstream library does not implement a connect timeout if the device can not be reached. This PR is to ensure HA can still operate normally in that case.

2023-07-15 09:45:36.183 WARNING (MainThread) [homeassistant.bootstrap] Waiting on integrations to complete setup: androidtv_remote
2023-07-15 09:46:36.271 WARNING (MainThread) [homeassistant.bootstrap] Waiting on integrations to complete setup: androidtv_remote
2023-07-15 09:46:56.046 WARNING (MainThread) [homeassistant.config_entries] Config entry 'TV' for androidtv_remote integration not ready yet: Couldn't connect to 192.168.123.123:6466; Retrying in background

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @tronikos, @Drafteed, mind taking a look at this pull request as it has been labeled with an integration (androidtv_remote) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of androidtv_remote can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign androidtv_remote Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR concept is fine, but we prefer to use the async_timeout library for timeouts.

@home-assistant home-assistant bot marked this pull request as draft July 19, 2023 09:07
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

quthla and others added 2 commits July 19, 2023 11:08
Co-authored-by: Erik Montnemery <erik@montnemery.com>
Co-authored-by: Erik Montnemery <erik@montnemery.com>
@quthla
Copy link
Contributor Author

quthla commented Jul 19, 2023

The PR concept is fine, but we prefer to use the async_timeout library for timeouts.

Done

@quthla quthla marked this pull request as ready for review July 19, 2023 09:10
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @quthla 👍

@emontnemery
Copy link
Contributor

Lint still failing, sorry about that.
Please make sure to test the changes locally after introducing my suggested changed, I did not do that myself, I just meant to illustrate the concept 🙈

@emontnemery emontnemery self-requested a review July 19, 2023 09:22
@quthla
Copy link
Contributor Author

quthla commented Jul 19, 2023

Lint still failing, sorry about that. Please make sure to test the changes locally after introducing my suggested changed, I did not do that myself, I just meant to illustrate the concept 🙈

No worries. Fixed it already.

@cgarwood cgarwood added the smash Indicator this PR is close to finish for merging or closing label Jul 19, 2023
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emontnemery emontnemery added this to the 2023.7.3 milestone Jul 20, 2023
@emontnemery emontnemery merged commit df19d4f into home-assistant:dev Jul 20, 2023
23 checks passed
frenck pushed a commit that referenced this pull request Jul 20, 2023
* Ensure androidtv_remote does not block startup of HA

* Fix lint

* Use asyncio.wait_for

* Update homeassistant/components/androidtv_remote/__init__.py

Co-authored-by: Erik Montnemery <erik@montnemery.com>

* Update homeassistant/components/androidtv_remote/__init__.py

Co-authored-by: Erik Montnemery <erik@montnemery.com>

* Fix lint

* Lint

* Update __init__.py

---------

Co-authored-by: Erik Montnemery <erik@montnemery.com>
@frenck frenck mentioned this pull request Jul 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
@quthla quthla deleted the patch-3 branch July 21, 2023 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants