Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add username to Reauth flow in Honeywell #96850

Merged
merged 4 commits into from Jul 19, 2023

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Jul 18, 2023

Breaking change

Proposed change

Allow user to change both username and password in rauth flow for Honeywell integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @rdfurman, mind taking a look at this pull request as it has been labeled with an integration (honeywell) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of honeywell can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign honeywell Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleaner code :)

homeassistant/components/honeywell/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/honeywell/config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft July 18, 2023 21:02
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

mkmer and others added 2 commits July 19, 2023 07:24
@mkmer mkmer marked this pull request as ready for review July 19, 2023 12:42
@home-assistant home-assistant bot requested a review from joostlek July 19, 2023 12:42
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments

homeassistant/components/honeywell/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/honeywell/config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft July 19, 2023 12:47
@mkmer mkmer marked this pull request as ready for review July 19, 2023 13:22
@home-assistant home-assistant bot requested a review from joostlek July 19, 2023 13:22
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joostlek joostlek merged commit 3b501fd into home-assistant:dev Jul 19, 2023
23 checks passed
@joostlek joostlek added this to the 2023.7.3 milestone Jul 19, 2023
@mkmer mkmer deleted the Honeywell_username branch July 19, 2023 13:25
frenck pushed a commit that referenced this pull request Jul 20, 2023
* pre-populate username/password on reauth

* Update homeassistant/components/honeywell/config_flow.py

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>

* Use add_suggested_value_to_schema

* Optimize code

---------

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@frenck frenck mentioned this pull request Jul 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honeywell TCC - Inability to Update Username / Only Password
3 participants