Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove miflora integration #96868

Merged
merged 1 commit into from Jul 18, 2023
Merged

Remove miflora integration #96868

merged 1 commit into from Jul 18, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Jul 18, 2023

Breaking change

The Miflora has been removed. It has been non-functioning for 12 months now and was fully replaced by the Xiaomi BLE integration.

Proposed change

See section above :)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Danielhiversen, @basnijholt, mind taking a look at this pull request as it has been labeled with an integration (miflora) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of miflora can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign miflora Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@frenck frenck marked this pull request as ready for review July 18, 2023 20:38
@frenck
Copy link
Member Author

frenck commented Jul 18, 2023

Marked ready for review. The documentation & brands all have been cleaned up previously.

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 18, 2023
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frenck frenck merged commit 4fefbf0 into dev Jul 18, 2023
47 checks passed
@frenck frenck deleted the frenck-2023-1054 branch July 18, 2023 21:15
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change cla-signed integration: miflora Quality Scale: No score remove-platform small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants