Improve availability of Tractive entities

[bieniu]

Breaking change

Proposed change

Sometimes the API returns null instead of values, this causes the sensor state to be unknown.

Also this may cause warnings for sensors that have numeric values as states and have a defined state_class.

With this change, entities are marked as unavailable during init and when an event with data is received, their availability is determined based on the condition value is not None. If the value is None, the entity will be unavailable.

Also, the handle_server_unavailable() and handle_status_update() functions have been moved to TractiveEntity to simplify the code.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Tractive entities are unknown or unavailable after HA start #98351
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @Danielhiversen, @zhulik, mind taking a look at this pull request as it has been labeled with an integration (tractive) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tractive can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign tractive Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[bieniu]

I think we have a race condition here, on my production system the entities after HA start are unavailable for 2-3 minutes. Probably entities are taking too long to initialize and are not getting the first events with data from TractiveClient. Probably this was also the reason for the previously unknown states. I think there was once an issue related to this, a user reported that switches are unavailable right after HA starts. @Danielhiversen @zhulik Do you have an idea how we can fix that?

[bieniu]

Now the event subscription starts when entities are initialized. On my production system, entities are available 2-3 seconds after HA starts.

[edenhaus]

Thanks @bieniu 👍

My requested changes are only small code style improvements :)

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[edenhaus]

I found a slight improvement. What do you think about it?

[edenhaus]

Some minor improvements to remove the assert.

[edenhaus]

Thanks @bieniu 🚀

[bieniu]

@edenhaus Thanks, we got a pretty nice refactoring of the code here 😁

[frenck]

Removed this PR from the milestone, as it causes conflicts and cannot be merged cleanly on the the rc branch for including in a patch release.

../Frenck