New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Alexa Unlock directive #97127
Conversation
Hi @marcheologo It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Hey there @home-assistant/cloud, @ochlocracy, @jbouwh, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentations says that this are the supported locales for :
ar-SA, de-DE, en-AU, en-CA, en-GB, en-IN, en-US, es-ES, es-MX, es-US, fr-CA, fr-FR, hi-IN, it-IT, ja-JP, pt-BR
See: https://www.developer.amazon.com/en-US/docs/alexa/device-apis/list-of-interfaces.html
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thnx @marcheologo 👍 I have taken the liberty of modifying the code to only allow the supported languages.
Enabled the Unlock directive from Alexa.LockController, it was disabled for most locales, enabled only for {"de-DE", "en-US", "ja-JP"}. Why? It's strange because the lock directive doesn't have this filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @marcheologo & @jbouwh 👍
../Frenck
Proposed change
Enabled the Unlock directive from
Alexa.LockController
for supported languages, it was disabled for most locales, enabled only for {"de-DE", "en-US", "ja-JP"}. Why? It's strange because the lock directive doesn't have this filterType of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: