New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Check date service for Workday #97280
Conversation
Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Taking a look at this as part of doing two reviews for my own PR. I left two small comments for minor cleanups, but overall this seems pretty reasonable to me.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Leaving this in draft as it's not allowed yet to use return values in services from integrations. |
Any idea when it will be permitted? Is it blocked by policy (and I could copy this to a custom component to get it earlier) or does Home Assistant itself not support this? |
f5a9d37
to
e471778
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gjohansson-ST 👍
Proposed change
Add a
check_date
service with response data.Example:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: