Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to SensorEntityDescriptions for Trafikverket Train #97318

Merged
merged 3 commits into from Aug 5, 2023

Conversation

gjohansson-ST
Copy link
Member

Proposed change

Break out from PR #71432

Prepare for moving attributes to sensors by:

  • Modify unique id for base entity
  • Implement SensorEntityDescription

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @endor-force, mind taking a look at this pull request as it has been labeled with an integration (trafikverket_train) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of trafikverket_train can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign trafikverket_train Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@joostlek joostlek added the smash Indicator this PR is close to finish for merging or closing label Jul 27, 2023
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final nitpicks

@home-assistant home-assistant bot marked this pull request as draft July 27, 2023 14:47
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek joostlek removed the smash Indicator this PR is close to finish for merging or closing label Jul 27, 2023
@gjohansson-ST gjohansson-ST marked this pull request as ready for review July 27, 2023 14:50
@home-assistant home-assistant bot requested a review from joostlek July 27, 2023 14:50
@gjohansson-ST gjohansson-ST added the smash Indicator this PR is close to finish for merging or closing label Jul 27, 2023
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the grammar nitpicks, but this looks better :)

@gjohansson-ST
Copy link
Member Author

Sorry for the grammar nitpicks, but this looks better :)

It does but I had to revert it as it would be breaking then. I have a breaking change in the follow-up PR so I will correct the spelling in that one.

@joostlek
Copy link
Member

👍🏻

@gjohansson-ST gjohansson-ST merged commit e4d9daf into dev Aug 5, 2023
21 checks passed
@gjohansson-ST gjohansson-ST deleted the tvt-migrate branch August 5, 2023 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants