Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored deprecated UNITS #97368

Merged
merged 6 commits into from Aug 3, 2023

Conversation

GrumpyMeow
Copy link
Contributor

Proposed change

I propose to refactor the deprecated use of units. This as it makes it easier for contributors to start contributing.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Jc2k, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (homekit_controller) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit_controller can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homekit_controller Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@GrumpyMeow
Copy link
Contributor Author

  • ##- @frenck would you be so kind to look at this generic PR?_

@frenck
Copy link
Member

frenck commented Jul 30, 2023

@GrumpyMeow Please don’t ping for reviews. Thanks 👍

@GrumpyMeow GrumpyMeow marked this pull request as ready for review August 1, 2023 13:02
Copy link
Member

@Jc2k Jc2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for this. Im a homekit_controller maintainer. If it was in a separate PR I would have reviewed and (probably) merged the homekit_controller parts. I'm not a maintainer for the other parts of this PR though so can't move this forwards.

@frenck
Copy link
Member

frenck commented Aug 1, 2023

This as it makes it easier for contributors to start contributing.

Just to highlight. This motivation has nothing to do with that.

../Frenck

tests/helpers/test_template.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft August 1, 2023 19:24
@home-assistant
Copy link

home-assistant bot commented Aug 1, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@GrumpyMeow GrumpyMeow marked this pull request as ready for review August 2, 2023 11:08
@home-assistant home-assistant bot requested a review from frenck August 2, 2023 11:08
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @GrumpyMeow 👍

../Frenck

@frenck frenck merged commit 6fd6002 into home-assistant:dev Aug 3, 2023
34 checks passed
@GrumpyMeow GrumpyMeow deleted the refactor_deprecated_units branch August 3, 2023 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants