Refactor Rest Sensor with ManualTriggerEntity #97396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @epenet, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
gjohansson-ST
force-pushed
the
rest-sensor-manualtriggerentity
branch
from
d01dea5
to
49c3cda
Compare
emontnemery
requested changes
Aug 10, 2023
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
gjohansson-ST
force-pushed
the
rest-sensor-manualtriggerentity
branch
from
2fa0cb8
to
8dbf267
Compare
8 tasks
|
Test failure (timeout) not related to this PR |
emontnemery
approved these changes
Aug 10, 2023
20 tasks
epenet
reviewed
Aug 11, 2023
|
|
||
| def _update_from_rest_data(self) -> None: | ||
| """Update state from the rest data.""" | ||
| value = self.rest.data_without_xml() | ||
|
|
||
| if self._json_attrs: | ||
| self._attr_extra_state_attributes = {} |
There was a problem hiding this comment.
Note: this changes the behavior in case of attribute parsing failure.
- previously, a failure would cause the attributes to a blank dict
- now, a failure causes the previous attributes to be kept
What this change on purpose? (also see #97526)
There was a problem hiding this comment.
We should not change this behavior in this PR at least.
So I see you have fixed that in the other PR so it comes back.
Thanks 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
SSIA
Requires: #97398
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: