Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Rest Binary sensor with ManualTriggerEntity #97400

Merged
merged 5 commits into from Aug 10, 2023

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Jul 28, 2023

Proposed change

SSIA

Requires: #97398

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @epenet, mind taking a look at this pull request as it has been labeled with an integration (rest) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rest can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign rest Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@gjohansson-ST gjohansson-ST force-pushed the rest-binary_sensor-manualtriggerentity branch from 5b62a11 to 2c3ce8c Compare August 6, 2023 15:51
@gjohansson-ST gjohansson-ST marked this pull request as ready for review August 6, 2023 15:51
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as on the switch PR.

homeassistant/components/rest/binary_sensor.py Outdated Show resolved Hide resolved
tests/components/rest/test_binary_sensor.py Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 10, 2023 07:38
@gjohansson-ST gjohansson-ST marked this pull request as ready for review August 10, 2023 08:40
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @gjohansson-ST 👍

@gjohansson-ST
Copy link
Member Author

Coverage not affected

---------- coverage: platform linux, python 3.11.4-final-0 -----------
Name                                             Stmts   Miss  Cover   Missing
------------------------------------------------------------------------------
homeassistant/components/rest/__init__.py          109      1    99%   198
homeassistant/components/rest/binary_sensor.py      71      0   100%
homeassistant/components/rest/const.py              20      0   100%
homeassistant/components/rest/data.py               73      5    93%   115-119
homeassistant/components/rest/entity.py             39      0   100%
homeassistant/components/rest/schema.py             14      0   100%
homeassistant/components/rest/sensor.py             74      0   100%
------------------------------------------------------------------------------
TOTAL                                              400      6    98%

@gjohansson-ST gjohansson-ST merged commit 4531dbb into dev Aug 10, 2023
29 of 30 checks passed
@gjohansson-ST gjohansson-ST deleted the rest-binary_sensor-manualtriggerentity branch August 10, 2023 10:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants