Add neato dismiss alert button

[maxcanna]

Breaking change

Proposed change

Adding a Dismiss Alert button to neato integration to be able to dismiss alerts preventing cleaning from start

Type of change

• Dependency upgrade https://github.com/stianaske/pybotvac/releases/tag/v0.0.24
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Add neato dismiss alert button home-assistant.io#28395

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @dshokouhi, @Santobert, mind taking a look at this pull request as it has been labeled with an integration (neato) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of neato can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign neato Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[gjohansson-ST]

Looks like this should be a button?

[maxcanna]

Looks like this should be a button?

Being a service you can use it however you want. Pushing a button or in an automation. I think it's more versatile

[gjohansson-ST]

You can push a button in an automation.
It's still a service button.press

[maxcanna]

You can push a button in an automation. It's still a service button.press

Yeah, I know but that would be overhead and imho not conceptually correct. It's a service which exposes a functionality

[gjohansson-ST]

Yeah, I know but that would be overhead and imho not conceptually correct. It's a service which exposes a functionality

Can't understand why it would be conceptually wrong? As probably there is a button or something you can click in the app to do this.
Should still be a button entity.

[maxcanna]

As probably there is a button or something you can click in the app to do this.

There's a button in the app to start the cleaning too. Nonetheless the custom cleaning is a service and not a button. I think it's better if it's a service, even for coherence.

I think it's best not to think UI first, and then interact with UI entities in code, but to think the other way around and expose something in the UI only when/if needed.

[Rudd-O]

Oh man this would be great.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[joostlek]

I just read the discussion and I share the opinion of @gjohansson-ST. The other service you mentioned takes arguments, so it requires more information to execute that action. In this case, it's something you can fire without extra information.

For automations, making it a service or making it a button makes no difference as both can be called and both would work. But the benefit for the button is in the usability for people who don't use it in an automation. If the button shares the same device info as the vacuum, the button will show up at the device page, allowing users to press it directly from the UI without having to create an integration or to run developer tools to call the service directly.

I found an example on my environment with Plex:

[gjohansson-ST]

Should be a button and not a custom service.
Please change this as already earlier said by myself and another developer.

[joostlek]

Oh and please include a changelog for the dependency you are updating in the PR description

[maxcanna]

Oh and please include a changelog for the dependency you are updating in the PR description

I linked the release in the PR description

[gjohansson-ST]

Tiny remarks left and then we're good

[joostlek]

Thanks!

Changes implemented