Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to sort options in select selector #97680

Merged
merged 2 commits into from Aug 3, 2023
Merged

Allow to sort options in select selector #97680

merged 2 commits into from Aug 3, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Aug 3, 2023

Proposed change

Options will be sorted alphabetically with this parameter.

Related Frontend PR : home-assistant/frontend#17468

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@piitaya
Copy link
Member Author

piitaya commented Aug 3, 2023

Thanks for the test fix @frenck. Missed that one 😅

Copy link
Contributor

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😀

@frenck
Copy link
Member

frenck commented Aug 3, 2023

Thanks, @farmio ❤️

PS: Something to consider for the selectors: Should the options be sorted? (regardless of translation).

@farmio
Copy link
Contributor

farmio commented Aug 3, 2023

The options source list is already sorted 😉
It has a suffix of group addresses and is not translated.

1/2/3 Bathroom Light

@frenck
Copy link
Member

frenck commented Aug 3, 2023

Aah right, in that case: It doesn't add much 👍

Thanks for clarifying that!

../Frenck

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @piitaya 👍

../Frenck

@frenck frenck merged commit 83af2f5 into dev Aug 3, 2023
34 checks passed
@frenck frenck deleted the sort_selector_select branch August 3, 2023 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants