Fix color mode attribute for both official and non official Hue lights #97683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Small bugfix for the colormode attribute of Philips Hue lights.
Recently we fixed a bug where non-official Hue lights did not set the colormode correctly but that bugfix introduced a side effect for official hue lights. After some testing it turns out that for non-official Hue lights there is no consequent, reliable way to detect if the light is in color temperature mode.
This fix will use an optimistic boolean for non official Hue lights to determine if the light is in color temperature mode, based on the last command (from HA) while relying on the official way for certified lights.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: