Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color mode attribute for both official and non official Hue lights #97683

Merged
merged 1 commit into from Aug 3, 2023

Conversation

marcelveldt
Copy link
Member

@marcelveldt marcelveldt commented Aug 3, 2023

Proposed change

Small bugfix for the colormode attribute of Philips Hue lights.
Recently we fixed a bug where non-official Hue lights did not set the colormode correctly but that bugfix introduced a side effect for official hue lights. After some testing it turns out that for non-official Hue lights there is no consequent, reliable way to detect if the light is in color temperature mode.

This fix will use an optimistic boolean for non official Hue lights to determine if the light is in color temperature mode, based on the last command (from HA) while relying on the official way for certified lights.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Aug 3, 2023

Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration (hue) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hue can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hue Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@marcelveldt marcelveldt added this to the 2023.8.1 milestone Aug 3, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marcelveldt 👍

../Frenck

@frenck frenck merged commit 6ed3184 into dev Aug 3, 2023
20 of 21 checks passed
@frenck frenck deleted the hue-attributes branch August 3, 2023 19:06
@Mariusthvdb
Copy link
Contributor

Mariusthvdb commented Aug 3, 2023

thx, can confirm this is working again, color has returned, and the attributes are correctly set, and displayed in the various frontend elements
(installed the Hue integration as CC)

@frenck frenck mentioned this pull request Aug 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hue lights are not changing their color attributes (but do change in real life)
4 participants