Fix NWS twice_daily forecast day/night detection

[karwosts]

Proposed change

In 2023.8, a standard is_daytime attribute was added to the weather platform (#75219). Also frontend weather was changed from looking for daytime attribute to is_daytime attribute.

NWS still uses daytime boolean for twice_daily forecast, meaning the frontend no longer recognizes the day/night information provided by NWS, so now it reports both day and night as "day".

Fix by change NWS to use the standard is_daytime attribute instead of daytime attribute.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue: Add new Forecasting to Weather #75219, Implement forecast types for Weather frontend#15028
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @MatthewFlamm, @kamiyo, mind taking a look at this pull request as it has been labeled with an integration (nws) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nws can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign nws Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[frenck]

Thanks, @karwosts 👍

As this is an error caused by a regression in our own base platform (and released broken right now), I'm going to override the codeowner approval to get this into the very next patch release.

../Frenck

[MatthewFlamm]

LGTM anyway, tested locally. Important to have this fixed while we update this integration with the new model. Thanks!

[frenck]

Awesome, thanks for the confirmation there @MatthewFlamm ❤️