Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to get_hosts_info on older Fritz!OS in AVM Fritz!Tools #97844

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Aug 5, 2023

Proposed change

This brings back the older get_hosts_info method (replaced in #96269 by get_hosts_attributes) in case the device does not support the newer api.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Aug 5, 2023

Hey there @mammuth, @AaronDavidSchneider, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (fritz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fritz Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@mib1185 mib1185 force-pushed the fritz/fallback-to-old-hosts_info-in-case-hosts_attributes-not-available branch from 1a4e8cf to a4389a9 Compare August 5, 2023 14:08
@mib1185 mib1185 marked this pull request as ready for review August 6, 2023 14:16
@mib1185
Copy link
Contributor Author

mib1185 commented Aug 7, 2023

additional working approval in #97543 (comment)

@frenck frenck merged commit d7a1b1e into home-assistant:dev Aug 8, 2023
21 checks passed
@mib1185 mib1185 deleted the fritz/fallback-to-old-hosts_info-in-case-hosts_attributes-not-available branch August 8, 2023 19:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FRITZ!Box WLAN 3370 has don't get host info
3 participants