Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace remaining utcnow calls + add ruff check #97964

Merged
merged 1 commit into from Aug 25, 2023

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Aug 7, 2023

Proposed change

Fix Python 3.12 deprecations, followup to #93684

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek

This comment was marked as outdated.

@cdce8p cdce8p changed the title Use datetime.now and datetime.fromtimestamp Replace remaining utcnow calls + add ruff check Aug 25, 2023
@cdce8p cdce8p marked this pull request as ready for review August 25, 2023 00:11
@cdce8p cdce8p requested review from frenck, Kane610 and a team as code owners August 25, 2023 00:11
@MartinHjelmare MartinHjelmare merged commit 72e6f79 into home-assistant:dev Aug 25, 2023
34 checks passed
@cdce8p cdce8p deleted the fix-datetime branch August 25, 2023 02:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants