Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore govee_ble state when gateway device becomes available #97984

Merged
merged 1 commit into from Aug 7, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 7, 2023

Proposed change

Some of the govee ble devices have multiple sensors that feed data through a primary / gateway device. When the gateway device goes out of range, all the sensors should become unavailable. When the gateway device returns to being in range, all the connected devices should also become available again. Currently we did not restore the state of connected devices and we only saw the one that we got advertisment for last.

uses the new restore method from #97462

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Some of the govee ble devices have multiple sensors that feed data through a
primary / gateway device. When the gateway device goes out of range, all
the sensors should become unavailable. When the gateway device returns to being
in range, all the connected devices should also become available again. Currently
we did not restore the state of connected devices and we only saw the one that
we got advertisment for last.

uses the new restore method from #97462
@home-assistant
Copy link

home-assistant bot commented Aug 7, 2023

Hey there @PierreAronnax, mind taking a look at this pull request as it has been labeled with an integration (govee_ble) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of govee_ble can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign govee_ble Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Contributor

@Ernst79 Ernst79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdraco
Copy link
Member Author

bdraco commented Aug 7, 2023

thanks

@bdraco bdraco merged commit b7f936f into dev Aug 7, 2023
21 checks passed
@bdraco bdraco deleted the govee_ble_restore branch August 7, 2023 19:13
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants