Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize ecobee weather #98023

Merged
merged 1 commit into from Aug 8, 2023
Merged

Modernize ecobee weather #98023

merged 1 commit into from Aug 8, 2023

Conversation

emontnemery
Copy link
Contributor

Deprecation

The ecobee weather entities have been updated:

  • The forecast state attribute is deprecated and will be removed in Home Assistant Core 2024.3, users should instead call the service weather.get_forecast

Proposed change

Modernize ecobee weather:

  • Add support for the weather.get_forecast service
  • Add support for daily weather forecasts

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery emontnemery added the deprecation Indicates a breaking change to happen in the future label Aug 8, 2023
@home-assistant
Copy link

home-assistant bot commented Aug 8, 2023

Hey there @marthoc, @marcolivierarsenault, mind taking a look at this pull request as it has been labeled with an integration (ecobee) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ecobee can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ecobee Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@emontnemery
Copy link
Contributor Author

Note: I'm not able to test this as I don't have any ecobee hardware

@frenck frenck merged commit 55619e7 into dev Aug 8, 2023
21 checks passed
@frenck frenck deleted the ecobee_modern_forecast branch August 8, 2023 10:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed deprecation Indicates a breaking change to happen in the future integration: ecobee Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants