-
-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calendar handle state updates at start/end of active/upcoming event #98037
Merged
allenporter
merged 6 commits into
home-assistant:dev
from
allenporter:calendar-event-state
Aug 26, 2023
Merged
Update calendar handle state updates at start/end of active/upcoming event #98037
allenporter
merged 6 commits into
home-assistant:dev
from
allenporter:calendar-event-state
Aug 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Remove unrelated changes and whitespace.
20 tasks
bachya
reviewed
Aug 18, 2023
bachya
approved these changes
Aug 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cla-signed
core
has-tests
integration: calendar
integration: google
integration: local_calendar
Quality Scale: internal
Quality Scale: No score
smash
Indicator this PR is close to finish for merging or closing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Update CalendarEntity to correctly handle state transitions for the start/end edge of an event that happens in-between the entities update interval. The CalendarEntity sets a timer/listener at the next "edge" which will perform another state write, re-evaluating the datetime of the next or upcoming calendar event.
This allows us to remove unnecessary games being played with polling intervals and fixes Google Calendar so that it works with
update_entity
(#44145)Additional work needed while in draft:
Previous related work:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: