New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add domestic_hot_water_setpoint number to Plugwise #98092
Conversation
Hey there @CoMPaTech, @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@gjohansson-ST thanks for reviewing and merging the other two Plugwise PR's! If you wouldn't mind, please review this PR too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bouwew 👍
But don't ping for reviews unless asked
Sorry if I was a bit too forward :) Very much appreciated for the reviewing and merging! |
Proposed change
Adding a new number:
domestic_hot_water_setpoint
, present on various OpenTherm boiler devices.Info for HA devs: on some systems there is only a
domestic_hot_water_setpoint
-sensor present, to differentiate in the backend we renamed the relevant output-key tomax_dhw_temperature
. The number-name is "corrected" instrings.json
.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: