Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domestic_hot_water_setpoint number to Plugwise #98092

Merged
merged 5 commits into from Aug 13, 2023

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Aug 9, 2023

Proposed change

Adding a new number: domestic_hot_water_setpoint, present on various OpenTherm boiler devices.

Info for HA devs: on some systems there is only a domestic_hot_water_setpoint-sensor present, to differentiate in the backend we renamed the relevant output-key to max_dhw_temperature. The number-name is "corrected" in strings.json.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Aug 9, 2023

Hey there @CoMPaTech, @frenck, mind taking a look at this pull request as it has been labeled with an integration (plugwise) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of plugwise can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign plugwise Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bouwew bouwew marked this pull request as ready for review August 9, 2023 06:14
@bouwew bouwew requested a review from frenck as a code owner August 9, 2023 06:14
@bouwew
Copy link
Contributor Author

bouwew commented Aug 13, 2023

@gjohansson-ST thanks for reviewing and merging the other two Plugwise PR's!

If you wouldn't mind, please review this PR too.

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bouwew 👍
But don't ping for reviews unless asked

@gjohansson-ST gjohansson-ST merged commit b41d3b4 into home-assistant:dev Aug 13, 2023
21 checks passed
@bouwew bouwew deleted the pw_max_dhw_temp branch August 13, 2023 12:03
@bouwew
Copy link
Contributor Author

bouwew commented Aug 13, 2023

Sorry if I was a bit too forward :)

Very much appreciated for the reviewing and merging!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants