Migrate EAFM to has entity name

[joostlek]

Proposed change

Migrate EAFM to has entity name

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @Jc2k, mind taking a look at this pull request as it has been labeled with an integration (eafm) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of eafm can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign eafm Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[Jc2k]

Is it required to set _attr_name to None? (Just want to be sure that's not the default or anything, otherwise this looks good if CI is happy).

[joostlek]

Is it required to set _attr_name to None? (Just want to be sure that's not the default or anything, otherwise this looks good if CI is happy).

When you set _attr_name to None, it will explicitly use the name of the device as entity name.

And since the device name was already the name of the entity, this doesn't change anything more.

I believe the best benefit you get from this change is that if you edit your device name, your entity name changes as well

[Jc2k]

I thought setting has_entity_name and not defining self.name was enough but it's been a while, so wanted to check.

[joostlek]

I think in .6 or .7 they added a log message warning that the device name is set as the entity name implicitly and that they should open an issue.

Found an example:
Entity None (<class 'homeassistant.components.tuya.switch.TuyaSwitchEntity'>) is implicitly using device name by not setting its name. Instead, the name should be set to None, please create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+tuya%22

[Jc2k]

Lovely thanks for checking!