Add airtouch5 #98136

danzel · 2023-08-09T22:45:57Z

Proposed change

Add integration for the Airtouch 5 AC/Zone controller.
This has been used/tested by multiple people in the forum
The airtouch5py library is over here

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Add airtouch5 documentation home-assistant.io#28523
Link to brands pull request: Add airtouch5 logos brands#4594

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2023-08-09T22:46:01Z

Hi @danzel

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant

When adding new integrations, limit included platforms to a single platform. Please reduce this PR to a single platform

home-assistant · 2023-08-09T22:46:04Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

danzel · 2023-08-09T22:52:58Z

How essential is "When adding new integrations, limit included platforms to a single platform. Please reduce this PR to a single platform"?

I can remove them if needed, and then submit them after this is merged. Would rather just do 1 PR though.
(I'd keep the climate entity, that is the most important one)

edenhaus

I can remove them if needed, and then submit them after this is merged. Would rather just do 1 PR though.
(I'd keep the climate entity, that is the most important one)

Please remove all except one. This makes the PR smaller and it will be easier to review. Therefore the PR will be merged faster.

Can you please include a link to the third-party library repository? It will help the review :)

danzel · 2023-08-19T01:05:22Z

@edenhaus Removed all except climate, linked to the library in the initial post.
Thanks

edenhaus

I have done an initial review and have some feedback/questions.

.coveragerc

homeassistant/components/airtouch5/__init__.py

homeassistant/components/airtouch5/climate.py

homeassistant/components/airtouch5/manifest.json

homeassistant/components/airtouch5/entity.py

homeassistant/generated/config_flows.py

homeassistant/components/airtouch5/climate.py

danzel · 2023-08-21T22:08:40Z

Have fixed what I can from the comments and rebased to fix build issues.

Kaldek · 2023-10-05T09:00:22Z

Hi folks, can we please bump this one up in the queue please, it's been dragging on for a long time. I know we're only Australia and a tiny portion of the market, yada yada, but it has been a while.

edenhaus · 2023-10-11T10:20:18Z

A PR in draft will be considered still in progress and not ready for another review. Therefore, we give less attention to drafted PRs.
@danzel Please mark the PR ready for review by clicking "Ready for review" after implementing the requested changes.

Sorry but I have to ask you again to fix the merge conflicts first

Change ac name to match the previous hack integration

Check changes before trying to apply them New dep version to fix _id not wrapping around

edenhaus

Some small cleanups, and then we are ready to merge :)

homeassistant/components/airtouch5/config_flow.py

danzel · 2023-11-20T06:37:57Z

Some small cleanups, and then we are ready to merge :)

Done, thanks for all the reviews

edenhaus

Please add tests until CI is passing.
We require 100% test coverage of of the config flow and for all files not excluded by .coveragerc

bolistik · 2023-12-05T00:10:16Z

@danzel are you please able to complete the final checks on this one?

danzel · 2023-12-05T00:25:37Z

Eventually. Feel free to fix it yourself if you have the time

…

________________________________ From: bolistik ***@***.***> Sent: Tuesday, December 5, 2023 1:10:28 PM To: home-assistant/core ***@***.***> Cc: David Leaver ***@***.***>; Mention ***@***.***> Subject: Re: [home-assistant/core] Add airtouch5 (PR #98136) @danzel<https://github.com/danzel> are you please able to complete the final checks on this one? — Reply to this email directly, view it on GitHub<#98136 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAC767W2V626MDCCSUD37HLYHZQ7JAVCNFSM6AAAAAA3KU2GS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZG43TQMJSGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

edenhaus

There are some small simplifications. Otherwise, the PR is good to be merged :)

Please fix also the merge conflicts

homeassistant/components/airtouch5/config_flow.py

tests/components/airtouch5/test_config_flow.py

danzel · 2024-01-14T23:03:17Z

Changes applied, I needed to disable a warning to allow except Exception:, not sure why it wasn't required before.

edenhaus

Thanks @danzel 👍

edenhaus · 2024-01-16T09:05:37Z

@danzel Can you please implement the suggested changes in the docs PR?

emontnemery · 2024-01-23T07:27:20Z

(Close + reopen to re-run CI)

danzel · 2024-01-23T20:10:09Z

@danzel Can you please implement the suggested changes in the docs PR?

Sorry, I missed those, looks like you've applied them, thanks.

home-assistant bot added cla-needed has-tests new-integration integration: airtouch5 labels Aug 9, 2023

home-assistant bot previously requested changes Aug 9, 2023

View reviewed changes

home-assistant bot marked this pull request as draft August 9, 2023 22:46

This was referenced Aug 9, 2023

Add airtouch5 documentation home-assistant/home-assistant.io#28523

Merged

Add airtouch5 logos home-assistant/brands#4594

Merged

home-assistant bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Aug 9, 2023

danzel marked this pull request as ready for review August 9, 2023 22:53

edenhaus requested changes Aug 18, 2023

View reviewed changes

home-assistant bot marked this pull request as draft August 18, 2023 08:55

danzel marked this pull request as ready for review August 19, 2023 01:04

edenhaus requested changes Aug 21, 2023

View reviewed changes

home-assistant bot marked this pull request as draft August 21, 2023 07:53

danzel force-pushed the add-airtouch5 branch from 2010ba8 to ad864c7 Compare August 21, 2023 22:07

danzel added 4 commits October 13, 2023 13:07

Add AirTouch 5 integration

bb16122

airtouch5 - bump lib to fix reconnect issues

359b0cb

Change ac name to match the previous hack integration

Working towards intelligent auto support

c8d8fad

Check changes before trying to apply them New dep version to fix _id not wrapping around

AirTouch5 - Cover - Support open/close/set%

f930705

danzel marked this pull request as ready for review November 15, 2023 08:09

home-assistant bot requested a review from edenhaus November 15, 2023 08:09

edenhaus requested changes Nov 15, 2023

View reviewed changes

home-assistant bot marked this pull request as draft November 15, 2023 09:06

Apply changes from review

93b626f

danzel marked this pull request as ready for review November 20, 2023 06:38

home-assistant bot requested a review from edenhaus November 20, 2023 06:38

edenhaus requested changes Nov 20, 2023

View reviewed changes

home-assistant bot marked this pull request as draft November 20, 2023 13:09

This code cannot be hit, remove

c2cc3cf

danzel marked this pull request as ready for review December 19, 2023 02:03

home-assistant bot requested a review from edenhaus December 19, 2023 02:03

edenhaus requested changes Dec 28, 2023

View reviewed changes

home-assistant bot marked this pull request as draft December 28, 2023 12:59

danzel added 2 commits January 14, 2024 22:46

Merge remote-tracking branch 'home-assistant/dev' into add-airtouch5

77d796c

Suggestions from code review

8a90d7b

danzel marked this pull request as ready for review January 14, 2024 23:03

home-assistant bot requested a review from edenhaus January 14, 2024 23:03

edenhaus approved these changes Jan 16, 2024

View reviewed changes

emontnemery closed this Jan 23, 2024

emontnemery reopened this Jan 23, 2024

edenhaus merged commit e3a73c1 into home-assistant:dev Jan 23, 2024
98 of 99 checks passed

github-actions bot locked and limited conversation to collaborators Jan 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add airtouch5 #98136

Add airtouch5 #98136

danzel commented Aug 9, 2023 •

edited

home-assistant bot commented Aug 9, 2023

home-assistant bot left a comment

home-assistant bot commented Aug 9, 2023

danzel commented Aug 9, 2023 •

edited

edenhaus left a comment

danzel commented Aug 19, 2023

edenhaus left a comment

danzel commented Aug 21, 2023

Kaldek commented Oct 5, 2023 •

edited

edenhaus commented Oct 11, 2023

edenhaus left a comment

danzel commented Nov 20, 2023

edenhaus left a comment

bolistik commented Dec 5, 2023

danzel commented Dec 5, 2023 via email

edenhaus left a comment

danzel commented Jan 14, 2024

edenhaus left a comment

edenhaus commented Jan 16, 2024

emontnemery commented Jan 23, 2024

danzel commented Jan 23, 2024

Add airtouch5 #98136

Add airtouch5 #98136

Conversation

danzel commented Aug 9, 2023 • edited

Proposed change

Type of change

Additional information

Checklist

home-assistant bot commented Aug 9, 2023

home-assistant bot left a comment

Choose a reason for hiding this comment

home-assistant bot commented Aug 9, 2023

danzel commented Aug 9, 2023 • edited

edenhaus left a comment

Choose a reason for hiding this comment

danzel commented Aug 19, 2023

edenhaus left a comment

Choose a reason for hiding this comment

danzel commented Aug 21, 2023

Kaldek commented Oct 5, 2023 • edited

edenhaus commented Oct 11, 2023

edenhaus left a comment

Choose a reason for hiding this comment

danzel commented Nov 20, 2023

edenhaus left a comment

Choose a reason for hiding this comment

bolistik commented Dec 5, 2023

danzel commented Dec 5, 2023 via email

edenhaus left a comment

Choose a reason for hiding this comment

danzel commented Jan 14, 2024

edenhaus left a comment

Choose a reason for hiding this comment

edenhaus commented Jan 16, 2024

emontnemery commented Jan 23, 2024

danzel commented Jan 23, 2024

danzel commented Aug 9, 2023 •

edited

danzel commented Aug 9, 2023 •

edited

Kaldek commented Oct 5, 2023 •

edited