New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base entity for Dexcom #98158
Add base entity for Dexcom #98158
Conversation
Hey there @gagebenne, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Makes sense, thanks! I've been also curious about making it a Home Assistant device with two associated entity sensors. I'm going to run this branch as a custom component tonight to check your changes out. |
Haha that was my next PR going to be after this one got merged :). Since I don't have this device or integration (as I am just trying to convert every integration), can you maybe take a look at the rest of the info for a device (manufacturer/model/sw version/hw version)? |
Nothing along those lines unfortunately with the API Dexcom uses 😕. The lack of unique identifier is why I avoided devices originally. Username is about the most unique we can get. |
We can do entry_id, that gives a unique identifier per entry :) |
Ran with latest stable and pre-release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joostlek 👍
1579d65
to
6ecc5e3
Compare
Proposed change
Introduce base entity for Dexcom to allow adding device info in follow up PR
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: