Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base entity for Dexcom #98158

Merged
merged 1 commit into from Aug 16, 2023
Merged

Conversation

joostlek
Copy link
Member

Proposed change

Introduce base entity for Dexcom to allow adding device info in follow up PR

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @gagebenne, mind taking a look at this pull request as it has been labeled with an integration (dexcom) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of dexcom can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign dexcom Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@joostlek joostlek added the smash Indicator this PR is close to finish for merging or closing label Aug 10, 2023
@gagebenne
Copy link
Contributor

Makes sense, thanks! I've been also curious about making it a Home Assistant device with two associated entity sensors. I'm going to run this branch as a custom component tonight to check your changes out.

@joostlek
Copy link
Member Author

Makes sense, thanks! I've been also curious about making it a Home Assistant device with two associated entity sensors. I'm going to run this branch as a custom component tonight to check your changes out.

Haha that was my next PR going to be after this one got merged :).

Since I don't have this device or integration (as I am just trying to convert every integration), can you maybe take a look at the rest of the info for a device (manufacturer/model/sw version/hw version)?

@gagebenne
Copy link
Contributor

Nothing along those lines unfortunately with the API Dexcom uses 😕. The lack of unique identifier is why I avoided devices originally.

Username is about the most unique we can get.

@joostlek
Copy link
Member Author

joostlek commented Aug 11, 2023

We can do entry_id, that gives a unique identifier per entry :)

@gagebenne
Copy link
Contributor

Ran with latest stable and pre-release pydexcom and branch worked. Thanks!

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joostlek 👍

@edenhaus edenhaus merged commit b9203cb into home-assistant:dev Aug 16, 2023
21 checks passed
@joostlek joostlek deleted the dexcom_base_entity branch August 16, 2023 17:19
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality integration: dexcom Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants