New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options flow to OpenSky #98177
Add options flow to OpenSky #98177
Conversation
# Conflicts: # homeassistant/components/opensky/config_flow.py # tests/components/opensky/conftest.py # tests/components/opensky/test_config_flow.py # tests/components/opensky/test_sensor.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should either allow the user to insert a username/password during the initial config flow or update the docs to inform the user about the ability to configure the username/password.
Otherwise, the user doesn't know about it.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Oh right, I still have to open a docs PR. Did you take a look at the rest of the code already? |
Yes, the rest is fine. I wanted to know if you prefer to open a docs PR or add the username/password to the initial setup. |
I think I prefer this way as it's not needed for the API to be authenticated, this way I don't force all users to login to a service they never had to |
Proposed change
Add Options flow to Opensky.
In the options flow, users can fill in their username and password to authenticate and upgrade their update interval.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: