Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Verisure to 2.6.6 #98258

Merged
merged 7 commits into from Aug 25, 2023
Merged

Upgrade Verisure to 2.6.6 #98258

merged 7 commits into from Aug 25, 2023

Conversation

niro1987
Copy link
Contributor

@niro1987 niro1987 commented Aug 11, 2023

Proposed change

  • bump vsure==2.6.6 (changelog, this enables the trust cookie)
  • attempt reauth using trust cookie in _async_update_data

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (verisure) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of verisure can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign verisure Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@niro1987 niro1987 changed the title Verisure_trust Upgrade Verisure to 2.6.5 Aug 11, 2023
@niro1987
Copy link
Contributor Author

niro1987 commented Aug 16, 2023

@gjohansson-ST
For your info; after rebase I got this error from the migration. Might be nothing, but still wanted to let you know.
The integration did not load and had to be removed/added to fix the error.

2023-08-16 07:49:43.246 ERROR (MainThread) [homeassistant.config_entries] Error migrating entry *SANITIZED* for verisure
Traceback (most recent call last):
  File "/workspaces/homeassistant-core/homeassistant/config_entries.py", line 633, in async_migrate
    result = await component.async_migrate_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspaces/homeassistant-core/homeassistant/components/verisure/__init__.py", line 97, in async_migrate_entry
    del new_options[CONF_LOCK_DEFAULT_CODE]
        ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'lock_default_code'

@gjohansson-ST
Copy link
Member

@gjohansson-ST For your info; after rebase I got this error from the migration. Might be nothing, but still wanted to let you know. The integration did not load and had to be removed/added to fix the error.

Thanks @niro1987 !! I did not consider the key might not exist. A bugfix PR has been made.

@niro1987 niro1987 changed the title Upgrade Verisure to 2.6.5 Upgrade Verisure to 2.6.6 Aug 19, 2023
@niro1987 niro1987 marked this pull request as ready for review August 24, 2023 18:56
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @niro1987 👍

../Frenck

@frenck frenck merged commit c2713f0 into home-assistant:dev Aug 25, 2023
34 checks passed
@niro1987 niro1987 deleted the verisure_trust branch August 25, 2023 09:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verisure integration keeps logging out
3 participants