Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enphase switch platform and grid enable switch #98261

Merged
merged 4 commits into from Aug 11, 2023

Conversation

cgarwood
Copy link
Member

@cgarwood cgarwood commented Aug 11, 2023

Proposed change

Adds a switch platform to the enphase_envoy integration, and a switch to toggle grid power on/off for Enphase Ensemble systems that support going off-grid.

pyenphase/pyenphase@v1.3.0...v1.4.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bdraco, @dgomes, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (enphase_envoy) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of enphase_envoy can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign enphase_envoy Removes the current integration label and assignees on the pull request, add the integration domain after the command.

homeassistant/components/enphase_envoy/switch.py Outdated Show resolved Hide resolved
homeassistant/components/enphase_envoy/switch.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft August 11, 2023 14:20
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek
Copy link
Member

Oh and add the package diff

@cgarwood
Copy link
Member Author

doh, I always forget that. Added to original comment

@cgarwood cgarwood marked this pull request as ready for review August 11, 2023 14:23
@home-assistant home-assistant bot requested a review from joostlek August 11, 2023 14:23
@cgarwood cgarwood merged commit 4342a95 into home-assistant:dev Aug 11, 2023
34 checks passed
@cgarwood cgarwood deleted the ensemble_grid_enable branch August 11, 2023 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants