Create a ZHA repair when directly accessing a radio with multi-PAN firmware #98275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
balloob
reviewed
Aug 13, 2023
balloob
reviewed
Aug 13, 2023
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
c0ffeeca7
approved these changes
Aug 17, 2023
c0ffeeca7
reviewed
Aug 28, 2023
emontnemery
requested changes
Aug 31, 2023
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
emontnemery
approved these changes
Sep 1, 2023
bramkragten
pushed a commit
that referenced
this pull request
Sep 1, 2023
…rmware (#98275) * Add the SiLabs flasher as a dependency * Create a repair if the wrong firmware is detected on an EZSP device * Update homeassistant/components/zha/strings.json Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com> * Provide the ZHA config entry as a reusable fixture * Create a separate repair when using non-Nabu Casa hardware * Add unit tests * Drop extraneous `config_entry.add_to_hass` added in 021def4 * Fully unit test all edge cases * Move `socket://`-ignoring logic into repair function * Open a repair from ZHA flows when the wrong firmware is running * Fix existing unit tests * Link to the flashing section in the documentation * Reduce repair severity to `ERROR` * Make issue persistent * Add unit tests for new radio probing states * Add unit tests for new config flow steps * Handle probing failure raising an exception * Implement review suggestions * Address review comments --------- Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
When ZHA fails to start up, probe the currently-running firmware and open a repair issue linking to device-specific documentation explaining how to re-install Zigbee firmware:
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: